Added missing tests for Standalone fusebox shell#55460
Added missing tests for Standalone fusebox shell#55460chicio wants to merge 4 commits intofacebook:mainfrom
Conversation
…standalone_fusebox_shell_test_improvements
…standalone_fusebox_shell_test_improvements
|
Hi @Abbondanzo, I created yet another PR to add some missing test 😅 (I'm using this pr to explore the code base). Can you help me to import also this one? Sorry to continuously bother you. I hope my small contributions are helpful 🙏 PS this one I think can be helpful because it is on something new. Thanks again 🙏 |
All good! The contributions are always welcome, they help a ton so thanks for making them 😄 |
|
@Abbondanzo has imported this pull request. If you are a Meta employee, you can view this in D93157076. |
Thank you so much @Abbondanzo!! This weekend I will find a new thing to explore/work on It is always a pleasure to meet someone so supportive 🙏 |
Summary:
This PR adds the missing test coverage for the standalone Fusebox debugger shell in
StandaloneFuseboxShell-test.First, I added some missing expectation for the success case (
enableStandaloneFuseboxShell=trueand no errors) already present:unstable_prepareFuseboxShellis called just one time during middleware initializationlaunchDebuggerAppWindowis never called when the standalone shell is availableThen, I added the missing test for the case when
unstable_prepareFuseboxShellreturns one of the error code like eg.platform_not_supported(as reported also in the TODO that I removed).In this way now the test is verifying the full behaviour for the new standalone mode for debugger/dev tools.
Changelog:
[GENERAL] [CHANGED] - Added missing tests for Standalone fusebox shell
Test Plan:
StandaloneFuseboxShell-testand verify all tests cases passedDefaultBrowserLauncherinopenDebuggerMiddlewareto verify that the tests were correctly failing