Handle CSRF token failures gracefully on login page#8331
Merged
Conversation
Rescue ActionController::InvalidAuthenticityToken in the sessions controller and redirect back to the login page with a friendly flash message instead of showing a 422 error. This handles common cases like stale sessions, browser back button, and multiple tabs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The inline rescue in the create method body never triggers because CSRF verification runs as a before_action. Use rescue_from to properly catch the exception. Fix test to enable real forgery protection instead of stubbing a private method (blocked by Mocha config). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ActionController::InvalidAuthenticityTokeninAuth::SessionsController#createand redirect back to the login page with a flash message instead of showing a 422 errorBCrypt::Errors::InvalidHashin the same methodTest plan
bundle exec rails test test/controllers/auth/sessions_controller_test.rb🤖 Generated with Claude Code