Conversation
| env: | ||
| SAAS_HOST: ${{ secrets.INTEGRATION_TEAM_SAAS_STAGING_HOST }} | ||
| SAAS_ACCOUNT_ID: ${{ secrets.INTEGRATION_TEAM_SAAS_STAGING_ACCOUNT_ID }} | ||
| SAAS_PAT: ${{ secrets.INTEGRATION_TEAM_SAAS_STAGING_PAT }} | ||
| PROJECT_SHORT_TAG: SAPIPY |
| @@ -4,21 +4,24 @@ on: | |||
| workflow_call: | |||
There was a problem hiding this comment.
The workflows are mainly generated by PTB, but updated in a few places, which are commented.
Manual updated were required mainly for
- Add secrets for accessing SaaS instances
- Re- integrate the slow tests, which were marked with
pytest.mark.slowbefore
| env: | ||
| SAAS_HOST: ${{ secrets.INTEGRATION_TEAM_SAAS_STAGING_HOST }} | ||
| SAAS_ACCOUNT_ID: ${{ secrets.INTEGRATION_TEAM_SAAS_STAGING_ACCOUNT_ID }} | ||
| SAAS_PAT: ${{ secrets.INTEGRATION_TEAM_SAAS_STAGING_PAT }} | ||
| PROJECT_SHORT_TAG: SAPIPY |
| @@ -1,16 +1,13 @@ | |||
| from __future__ import annotations | |||
|
|
|||
There was a problem hiding this comment.
Main changes in this file are for handling results of type ApiError, which are new in version 0.26
of openapi-python-client.
Our updated implementation now raises an exception of type OpenApiError.
exasol/saas/client/api_access.py
Outdated
| wait_fixed, | ||
| ) | ||
|
|
||
| import exasol.saas.client.openapi.models as openapi_models |
There was a problem hiding this comment.
The linter coming with PTB version 5 does no longer accept
from exasol.saas.client import openapi
openapi.models.CreateDatabaseInitialCluster(...)There was a problem hiding this comment.
I think, we saw something similar in another project; the linter requires explicit exports if you want to import things. The explicit export can be happen by definition or by __all__
TypeError: isinstance() argument 2 cannot be a parameterized generic
|
|
|
||
|
|
||
| # TODO: Create Unit test | ||
| def ensure_type( |
There was a problem hiding this comment.
expected: type[T]
raises TypeError: isinstance() argument 2 cannot be a parameterized generic
expected: type and return response
causes mypy error Incompatible return value type (got "object", expected "T")
|



This PR closes the following issues
openapi-python-clientapi_access.pyto processApiErrorsnoxconfig.pyneeded to be updatedCloses #120
Closes #141
Closes #140