feat(ampctl): print success message after dataset registration#1941
Merged
shiyasmohd merged 1 commit intomainfrom Mar 9, 2026
Merged
feat(ampctl): print success message after dataset registration#1941shiyasmohd merged 1 commit intomainfrom
shiyasmohd merged 1 commit intomainfrom
Conversation
LNSD
requested changes
Mar 9, 2026
Contributor
LNSD
left a comment
There was a problem hiding this comment.
We should also print the manifest hash. So the output would actually look like:
Human mode (with tag):
✓ Dataset my-org/my-dataset@v1.0 registered successfully (hash: a1b2c3d4e5f6...)
Human mode (no tag):
✓ Dataset my-org/my-dataset registered successfully (hash: a1b2c3d4e5f6...)
JSON mode (with tag):
{"fqn":"my-org/my-dataset","tag":"v1.0","hash":"a1b2c3d4e5f678901234567890abcdef1234567890abcdef1234567890abcdef"}JSON mode (no tag):
{"fqn":"my-org/my-dataset","tag":null,"hash":"a1b2c3d4e5f678901234567890abcdef1234567890abcdef1234567890abcdef"}7b14003 to
7e553ae
Compare
LNSD
reviewed
Mar 9, 2026
LNSD
reviewed
Mar 9, 2026
7e553ae to
30ef730
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example Output
Json Output