Skip to content

feat(ampctl): print success message after dataset registration#1941

Merged
shiyasmohd merged 1 commit intomainfrom
shiyasmohd/print-success-after-register
Mar 9, 2026
Merged

feat(ampctl): print success message after dataset registration#1941
shiyasmohd merged 1 commit intomainfrom
shiyasmohd/print-success-after-register

Conversation

@shiyasmohd
Copy link
Contributor

@shiyasmohd shiyasmohd commented Mar 9, 2026

Example Output

Screenshot 2026-03-09 at 5 23 52 PM

Json Output

{"namespace":"shiyas","name":"mainnet","version":"0.0.1","manifest_hash":"fc81821e5253d6d3f9735fe295d4de775870c95176b4c1c118c236ef0d4d4d52","kind":"evm-rpc","start_block":100,"finalized_blocks_only":false,"tables":["blocks","transactions","logs"]}

@shiyasmohd shiyasmohd self-assigned this Mar 9, 2026
@shiyasmohd shiyasmohd requested a review from LNSD March 9, 2026 06:30
Copy link
Contributor

@LNSD LNSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also print the manifest hash. So the output would actually look like:

Human mode (with tag):

  ✓ Dataset my-org/my-dataset@v1.0 registered successfully (hash: a1b2c3d4e5f6...)

Human mode (no tag):

  ✓ Dataset my-org/my-dataset registered successfully (hash: a1b2c3d4e5f6...)

JSON mode (with tag):

  {"fqn":"my-org/my-dataset","tag":"v1.0","hash":"a1b2c3d4e5f678901234567890abcdef1234567890abcdef1234567890abcdef"}

JSON mode (no tag):

  {"fqn":"my-org/my-dataset","tag":null,"hash":"a1b2c3d4e5f678901234567890abcdef1234567890abcdef1234567890abcdef"}

@shiyasmohd shiyasmohd force-pushed the shiyasmohd/print-success-after-register branch from 7b14003 to 7e553ae Compare March 9, 2026 10:08
@shiyasmohd shiyasmohd force-pushed the shiyasmohd/print-success-after-register branch from 7e553ae to 30ef730 Compare March 9, 2026 11:53
Copy link
Contributor

@LNSD LNSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@shiyasmohd shiyasmohd merged commit b3d975e into main Mar 9, 2026
8 checks passed
@shiyasmohd shiyasmohd deleted the shiyasmohd/print-success-after-register branch March 9, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants