Fixing flash attn in ddp diffusion model#2002
Draft
Jubeku wants to merge 2 commits intomk/mh/diffusion-single-samplefrom
Draft
Fixing flash attn in ddp diffusion model#2002Jubeku wants to merge 2 commits intomk/mh/diffusion-single-samplefrom
Jubeku wants to merge 2 commits intomk/mh/diffusion-single-samplefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running multi-gpu training with
fe_diffusion_model: Truewe get illegal memory access error caused during back propagation in the varlen attention.In this PR we tried to implement following fixes, however the issue persists.
.contiguous()to all q/k/v tensors before they enter flash attention,Not within this PR, we implemented Torch's SDPA as an alternative to the varlen attention. This indeed fixed the error, but it not what we want because of the memory overhead. Still, if the problem persists, we might use it as an intermediate solution to run diffusion experiments in multi-gpu setting.
Issue Number
Fixes #1999
Is this PR a draft? Mark it as draft.
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60