Skip to content

Comments

N&N entry - Added a button to show launch bundles#491

Open
nburnwal09 wants to merge 1 commit intoeclipse-platform:masterfrom
nburnwal09:add_showBundles
Open

N&N entry - Added a button to show launch bundles#491
nburnwal09 wants to merge 1 commit intoeclipse-platform:masterfrom
nburnwal09:add_showBundles

Conversation

@nburnwal09
Copy link

Added a feature to show launch bundles: eclipse-pde/eclipse.pde#1922

@nburnwal09
Copy link
Author

@merks
Kindly review this PR.

Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly okay. Looking from my phone.

news/4.39/pde.md Outdated

## Views and Dialogs

### Added a button to show launch bundles in launch configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a short title case title.

news/4.39/pde.md Outdated
<summary>Contributors</summary>

- [Neha Burnwal ](https://github.com/nburnwal09)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It this blank line necessary?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No not necessarily. Removed it

news/4.39/pde.md Outdated
![Show launch bundles button](images/show_launchBundles_btn.png)
![Launch bundles dialog](images/launchBundles_dialog.png)

It provides visibility into the resolved bundle list for both plug-in based and feature based applications.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feature-based with a hyphen

@nburnwal09 nburnwal09 force-pushed the add_showBundles branch 2 times, most recently from cf4301e to 1e0e646 Compare February 18, 2026 07:04
@nburnwal09
Copy link
Author

@merks
I have updated the changes. Kindly review.

Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This button looks like this:

Image

It should use title case shouldn't it? And shouldn't it has a ...? I'm not sure the rule for ....

@nburnwal09
Copy link
Author

This button looks like this:

Image It should use title case shouldn't it? And shouldn't it has a `...`? I'm not sure the rule for `...`.

Okay, I noticed it's title case for other buttons as well.
But ... seems not relatable here, like we show information via Show Command Line it also shows the info of the bundles. But again, I am not aware of the rules.

For title case, I will raise the PR. Meanwhile, is it okay to take this N&N forward?

@merks
Copy link
Contributor

merks commented Feb 19, 2026

Meanwhile, is it okay to take this N&N forward?

Can you make a corrected screenshot?

@nburnwal09
Copy link
Author

@merks

There are 2 reason for not implementing the shrink wrapping here:

  1. The button length seems to be reasonably fitting the row.
  2. While group of buttons are there, for eg. in the screenshot on the right hand side, the button Select Working Set..has ... to align it properly with other button. It makes sense to shrink wrap the text to show uniform width.
    The bottom buttons do not follow that and they have all different lengths.
image

But even if you suggest to add shrink wrapping, I will do it in the next iteration.

@nburnwal09
Copy link
Author

@merks
I have updated the image here with title case in Show Launch Bundles.
Kindly review it.

@nburnwal09 nburnwal09 requested a review from merks February 20, 2026 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants