Open
Conversation
优化手机端显示溢出的问题,目前手机端 是按照PC端开始日期和结束日期并排,优化后,手机端开始日期和结束日期采取上下排列
|
Thanks for your PR, @Tony-ST0754. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts DateTimeRange layout for mobile to prevent overflow and refines DatePicker footer layout, primarily through CSS changes. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Changing
.range-panel-bodytoflex-direction: columnglobally formax-width: 768pxmay unintentionally affect other components using this class; consider scoping the media rule under the.datetime-rangecontainer (or a more specific selector) so the behavior change is limited to this component. - The footer markup now relies on
justify-content-between, which only takes effect on flex containers; double-check that.picker-panel-footerhasdisplay: flexapplied in the relevant stylesheet, otherwise the intended layout changes on the DatePicker footer may not work as expected.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Changing `.range-panel-body` to `flex-direction: column` globally for `max-width: 768px` may unintentionally affect other components using this class; consider scoping the media rule under the `.datetime-range` container (or a more specific selector) so the behavior change is limited to this component.
- The footer markup now relies on `justify-content-between`, which only takes effect on flex containers; double-check that `.picker-panel-footer` has `display: flex` applied in the relevant stylesheet, otherwise the intended layout changes on the DatePicker footer may not work as expected.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7790 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 764 764
Lines 34111 34111
Branches 4697 4697
=========================================
Hits 34111 34111
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #7789
问题描述 / Problem Description
当前DateTimeRange 组件不管在移动动还是PC端,选择日期范围时,开始日期、结束日期面版,是采取横向并排,在手机端会产生溢出屏幕的问题,即结束日期面板会挤出屏幕。
优化后 / Optimized
优化后,平板或PC端开始日期、结束日期面版继续采取原来横向并排显示;手机端开始日期和结束日期采取上下排列
前后对比 / Befor & After
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Adjust DateTime range and picker panel layouts for better responsiveness and spacing, especially on mobile devices.
Bug Fixes:
Enhancements: