Open
Conversation
Member
Author
|
@dotnet/jit-contrib PTAL |
github-actions
bot
added
the
area-CodeGen-coreclr
Contributor
There was a problem hiding this comment.
Pull request overview
Adds initial WASM RyuJit codegen support for GT_BITCAST, enabling bit reinterpretation operations to be emitted as native Wasm reinterpret opcodes.
Changes:
- Dispatch
GT_BITCASTinCodeGen::genCodeForTreeNode. - Add
CodeGen::genCodeForBitCastimplementation in the WASM code generator to emit Wasm reinterpret instructions.
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
3 tasks
kg
approved these changes
Feb 8, 2026
src/coreclr/jit/codegenwasm.cpp
Outdated
| var_types fromType = tree->gtGetOp1()->TypeGet(); | ||
|
|
||
| assert(toType == genActualType(tree)); | ||
| assert(fromType == genActualType(tree->gtGetOp1())); |
Contributor
There was a problem hiding this comment.
This assert won't hold. The operand can be of arbitrary type (incl. small ones). It needs to be genActualTyped explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.