Redo model validation to stop looping for every check#37646
Draft
roji wants to merge 1 commit intodotnet:mainfrom
Draft
Redo model validation to stop looping for every check#37646roji wants to merge 1 commit intodotnet:mainfrom
roji wants to merge 1 commit intodotnet:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@AndriySvyryd there's some additional potential cleanup/refactor, but this is a solid 1st step - let me know what you think. I suggest we iterate here with whatever works fastest, i.e. if you want changes, it's probably better to check this out and do them (or ask copilot to do them) rather than comment (as this more your owned area in any case). But am open to doing it in whatever way you prefer.
Closes #37645