Update minimum supported date for .NET 11#12207
Merged
gewarren merged 3 commits intodotnet:mainfrom Jan 8, 2026
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-globalization |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the JapaneseCalendar documentation and code examples to reflect the new minimum supported date for .NET 11. The minimum supported date changes from September 8, 1868 to October 23, 1868 C.E. in the Gregorian calendar.
Key changes:
- Updated
MinSupportedDateTimeproperty documentation to specify October 23, 1868 as the new minimum date for .NET 11 - Added version notes clarifying the date difference between .NET 10 and earlier versus .NET 11
- Removed
?displayProperty=nameWithTypefrom various xref property references for cleaner formatting - Modernized C# code examples to use top-level statements and target constructors
- Reformatted and updated code snippet output to reflect the new dates
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| xml/System.Globalization/JapaneseCalendar.xml | Updated MinSupportedDateTime documentation, added version notes, cleaned up xref formatting, and corrected whitespace |
| snippets/csharp/System.Globalization/JapaneseCalendar/MaxSupportedDateTime/japanesecalendar_minmax.cs | Modernized code to top-level statements, updated expected output for .NET 11 with new minimum date |
| snippets/csharp/System.Globalization/JapaneseCalendar/MaxSupportedDateTime/Project.csproj | Changed output type to Exe and target framework to net10.0 |
| snippets/visualbasic/System.Globalization/JapaneseCalendar/MaxSupportedDateTime/japanesecalendar_minmax.vb | Reformatted code, updated expected output for .NET 11 with new minimum date |
| snippets/visualbasic/System.Globalization/JapaneseCalendar/MaxSupportedDateTime/Project.vbproj | Added new project file targeting net10.0 with Exe output type |
...lbasic/System.Globalization/JapaneseCalendar/MaxSupportedDateTime/japanesecalendar_minmax.vb
Show resolved
Hide resolved
snippets/csharp/System.Globalization/JapaneseCalendar/MaxSupportedDateTime/Project.csproj
Show resolved
Hide resolved
snippets/visualbasic/System.Globalization/JapaneseCalendar/MaxSupportedDateTime/Project.vbproj
Show resolved
Hide resolved
tarekgh
approved these changes
Jan 7, 2026
BillWagner
approved these changes
Jan 8, 2026
Member
BillWagner
left a comment
There was a problem hiding this comment.
This LGTM, once you address the open conversations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/docs#50894.