-
Notifications
You must be signed in to change notification settings - Fork 8.2k
pagefind v1.5.0 #24092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
pagefind v1.5.0 #24092
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
71376cf
agents: add fetch toolset to docs_engineer agent
dvdksn fa18c7f
site: upgrade pagefind to v1.5.0-beta.1
dvdksn 0150180
site: remove /search page, redirect to homepage
dvdksn f929b8f
site: implement pagefind component ui for search modal
dvdksn 77645c2
site: add pagefind metadata for improved search ranking
dvdksn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /* Pagefind Component UI Customizations */ | ||
|
|
||
| /* Dark mode variables for modal */ | ||
| .dark pagefind-modal { | ||
| --pf-text: var(--color-gray-100); | ||
| --pf-text-secondary: var(--color-gray-300); | ||
| --pf-text-muted: var(--color-gray-400); | ||
| --pf-background: var(--color-gray-900); | ||
| --pf-border: var(--color-gray-700); | ||
| --pf-border-focus: var(--color-blue-400); | ||
| --pf-hover: var(--color-gray-800); | ||
| } | ||
|
|
||
| /* Highlight marks in results */ | ||
| pagefind-results mark { | ||
| background-color: var(--color-yellow-200); | ||
| color: inherit; | ||
| padding: 0 0.125rem; | ||
| border-radius: 0.125rem; | ||
| } | ||
|
|
||
| .dark pagefind-results mark { | ||
| background-color: rgba(255, 204, 72, 0.3); | ||
| color: white; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -290,6 +290,7 @@ agents: | |
|
|
||
| toolsets: | ||
| - type: filesystem | ||
| - type: fetch | ||
| - type: shell | ||
| - type: todo | ||
| - type: script | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,13 @@ | ||
| <nav | ||
| id="breadcrumbs" | ||
| {{- $breadcrumbTitles := slice }} | ||
| data-pagefind-ignore | ||
| class="breadcrumbs mb-4 flex min-w-0 items-center gap-2 text-gray-400 dark:text-gray-300" | ||
| > | ||
| {{ range .Ancestors.Reverse }} | ||
| {{ $breadcrumbTitles = $breadcrumbTitles | append .LinkTitle }} | ||
| <a href="{{ .Permalink }}" class="link truncate" | ||
| >{{ markdownify .LinkTitle }}</a | ||
| > | ||
| <span>/</span> | ||
| {{- end }} | ||
| <span | ||
| data-pagefind-meta="breadcrumbs:{{ collections.Delimit $breadcrumbTitles " / " }}" | ||
| class="truncate" | ||
| >{{ markdownify .LinkTitle }}</span | ||
| > | ||
| <span class="truncate">{{ markdownify .LinkTitle }}</span> | ||
| </nav> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| {{/* Pagefind metadata - must be inside data-pagefind-body */}} | ||
| {{- $description := partial "utils/description.html" . -}} | ||
| {{- $keywords := partialCached "utils/keywords.html" . . -}} | ||
| {{- $breadcrumbs := slice -}} | ||
| {{- range .Ancestors.Reverse -}} | ||
| {{- $breadcrumbs = $breadcrumbs | append .LinkTitle -}} | ||
| {{- end -}} | ||
| {{- with $description }}<meta data-pagefind-meta="description:{{ . }}">{{ end }} | ||
| {{- with $keywords }}<meta data-pagefind-meta="keywords:{{ delimit . ", " }}">{{ end }} | ||
| {{- with $breadcrumbs }}<meta data-pagefind-meta="breadcrumbs:{{ delimit . " / " }}">{{ end }} | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hugo comment could be more specific about the technical requirement
The comment "must be inside data-pagefind-body" explains the constraint but not the reason behind it.
Per documentation standards for complete explanations, consider clarifying:
This helps developers understand both the constraint and its purpose.