-
Notifications
You must be signed in to change notification settings - Fork 8.2k
hub: add deletion note #24078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
hub: add deletion note #24078
Conversation
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation Review
Found a few opportunities to tighten the language and remove hedging words per the style guide. These are minor style improvements - the content is clear and helpful.
✨ Positive notes:
- Helpful addition of deletion latency information
- Good consolidation of the bulk deletion note into the introduction
- Clear explanation of automatic retry behavior
|
/review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation Review Complete ✅
No issues found in the changed content. The additions are:
- Clear and accurate: Properly explains timeout behavior and automatic retry mechanism
- Well-structured: Appropriate note callouts with helpful context
- Consistent: Uses correct syntax for both markdown and YAML contexts
The documentation changes effectively communicate the deletion timeout behavior to users across both the UI guide and API reference.
Description
Delete operation may time-out. Hub automatically retries without user interaction in both the UI and API.
Added notes to make the user aware.
Related issues or tickets
ENGDOCS-3173
Reviews