fix: exclude hook_test.go from Windows builds and propagate ExecStart error in runWaitExec#13683
Open
pawannn wants to merge 2 commits intodocker:mainfrom
Open
fix: exclude hook_test.go from Windows builds and propagate ExecStart error in runWaitExec#13683pawannn wants to merge 2 commits intodocker:mainfrom
pawannn wants to merge 2 commits intodocker:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a Windows-native go test build failure by excluding PTY-dependent tests in pkg/compose from Windows builds, addressing issue #13682 where console.NewPty() is unavailable on Windows.
Changes:
- Add
//go:build !windowsbuild constraint topkg/compose/hook_test.goto skip Unix-only PTY tests on Windows.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pawannn
changed the title
pawannn
force-pushed
the
fix/hook-test-windows-build-tag
branch
from
d6395bc to
1c97629
Compare
pawannn
changed the title
pawannn
changed the title
…er#13682) Signed-off-by: pawannn <pawankalyan1614@gmail.com>
Signed-off-by: pawannn <pawankalyan1614@gmail.com>
pawannn
force-pushed
the
fix/hook-test-windows-build-tag
branch
from
cbcdcbb to
d199446
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
//go:build !windowsbuild constraint topkg/compose/hook_test.goto exclude PTY-dependent tests from native Windows builds.console.NewPty()is Unix-only and caused a compile-time failure when running go test on Windows.runWaitExecwhereExecStartfailure was returning nil instead of propagating the error, which could cause lifecycle hooks to silently appear successful when they never ran.Related issue
Fixes #13682
A picture of a cute animal
