publish: return api.ErrCanceled when user declines interactive prompts#13674
publish: return api.ErrCanceled when user declines interactive prompts#13674ishwar170695 wants to merge 1 commit intodocker:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR changes compose publish to return a detectable error when the user declines interactive safety prompts, instead of returning nil (success), so automation/callers can distinguish an abort from a successful publish.
Changes:
- Introduce a new sentinel error (
ErrPublishAborted) and return it when pre-check prompts are declined. - Add unit tests intended to cover “decline” paths for
preChecksandpublish.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pkg/compose/publish.go | Returns a sentinel error when publish is aborted via interactive decline. |
| pkg/compose/publish_test.go | Adds tests for decline behavior in pre-checks and publish. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Ishwar <ishwarcm@iitbhilai.ac.in>
dc3c9cb to
579bbe7
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Updated PR description to reflect the use of the existing api.ErrCanceled instead of creating a new custom error. |
What I did
Previously, declining the bind mount or sensitive data warning prompt caused publish() to return
nil, which is indistinguishable from success for callers and automation scripts (exit code 0).Change publish() to return the existing
api.ErrCanceledsentinel so callers can detect user-initiated cancellation viaerrors.Is(). Add unit tests covering both thepreChecksdecline path and the fullpublish()path.Signed-off-by: Ishwar chand meena ishwarcm@iitbhilai.ac.in
(not mandatory) A picture of a cute animal, if possible in relation to what you did