scripts/warn-outside-container: fix font representation#6839
scripts/warn-outside-container: fix font representation#6839thaJeztah merged 1 commit intodocker:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
Thanks! I recall we had a PR for this, but it had some issues (#4211), so we can go with your PR instead; however, it looks like shellcheck linting is failing; can you fix that? (please amend the commit, so that there's only one commit in the PR)
|
Oh, i see! Yeah, i'll fix that asap |
literally-user
force-pushed
the
6838-fix-font-representation
branch
from
8f44542 to
914fd74
Compare
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
Thanks! I just tried, and looks like there was an issue; I posted the correct variant (you can copy/paste it.
Signed-off-by: Davlat Davydov <literally_user@hotmail.com> fix CI review changes
literally-user
force-pushed
the
6838-fix-font-representation
branch
from
914fd74 to
71db152
Compare
|
Looks like GitHub didn't trigger actions; let me try close/re-open. |
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM, thanks!
waiting for CI to do its thing; seems to still be having issues with some check 🫠
4 participants
Fixed font display in /scripts/warn-outside-container by replacing echo with POSIX-compatible prinf so that display works on any POSIX-compatible systems.
Fixes #6838