provider/anthropic: enforce tool sequencing, remove self-repair/validation #1680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation Stop inserting synthetic tool_result blocks and remove preflight sequencing validators. Instead, enforce Anthropic tool_use/tool_result adjacency and ID matching during message conversion (and preserve tool-call blocks during history trimming) so invalid histories fail fast with clear errors. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
rumpl
force-pushed
the
anthropic-tools
branch
from
d1b5b3e to
fac5c12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not need to validate and self-repair things, we should instead fail fast and make really sure that we have the right tools and tool results in the session.
An attempt at fixing #1644