Prevent title generation spinner to spin forever

[dgageot]

No description provided.

[github-actions]

Review Summary

⚠️ Critical Issue Found: Goroutine Leak Risk

This PR fixes the spinner issue by emitting events in error paths, but the new channel sends lack context cancellation protection. The generateTitle function runs as a goroutine and could leak if the context is cancelled while trying to send events.

Impact

• 3 new unprotected channel sends to a.events
• If context is cancelled, the event receiver stops reading (see Subscribe function)
• Once the 128-element buffer fills, the goroutine blocks forever

Fix Required

Wrap all channel sends with context cancellation checks:

select {
case a.events <- runtime.SessionTitle(a.session.ID, ""):
case <-ctx.Done():
    return
}

This pattern is used consistently throughout the codebase (lines 333-338, 363-367, 1077-1081).

fixed