Freeze v4 and bump config version to v5 #1635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Gageot <david.gageot@docker.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Review Complete - No Issues Found
This PR correctly implements the config versioning refactor:
Changes Verified
- Frozen v4 package: Correctly copies existing v4 config code into
pkg/config/v4/for backwards compatibility - Simplified latest/upgrade.go: Correctly simplified since v4→v5 upgrade doesn't require complex transformation (both use
[]AgentConfig) - Version bump: Latest package correctly updated from v4 to v5
- Upgrade chain: v4 correctly registered in
versions.goupgrade chain - Schema:
cagent-schema.jsoncorrectly updated to include version "5"
Structure Analysis
- v3.Config.Agents:
map[string]AgentConfig✅ - v4.Config.Agents:
[]AgentConfig✅ - v5(latest).Config.Agents:
[]AgentConfig✅
The v3→v4 upgrade (now in pkg/config/v4/upgrade.go) correctly handles map-to-slice conversion with order preservation. The v4→v5 upgrade (in pkg/config/latest/upgrade.go) correctly uses simple CloneThroughJSON since structures are identical.
No bugs found in the changed code. Good refactoring! 🚀
krissetto
approved these changes
Feb 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.