feat: add Ctrl+R reverse history search #1630
Merged
+769
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
reviewed
Feb 7, 2026
Member
|
Thanks for the PR @Mostamhd! |
Member
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review Summary
✅ No bugs found in the added code. The reverse history search implementation looks solid.
Analysis
Reviewed the new FindPrevContains and SetCurrent functions along with the editor integration. The code correctly:
- Handles edge cases (empty history, negative indices, out of bounds)
- Uses proper guards before calling
SetCurrent(checksmatchIdx >= 0) - Has comprehensive test coverage including boundary conditions
- Matches the documented API contract for exclusive upper bound behavior
The implementation is well-tested and handles edge cases appropriately.
Mostamhd
force-pushed
the
feature/ctrl-r-history-search
branch
from
39f9496 to
3b1e115
Compare
Signed-off-by: Moustafa Ahmed <mostamhd@proton.me>
Mostamhd
force-pushed
the
feature/ctrl-r-history-search
branch
from
3b1e115 to
931d90b
Compare
Contributor
Author
|
Hey @dgageot , thank you for the review! I have refactored the code and worked on the comments you mentioned. Feel free to let me know if you have any questions or comments. |
dgageot
approved these changes
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1615