Extends #445 to other providers which many provides deepseek#458
Extends #445 to other providers which many provides deepseek#458di-sukharev merged 2 commits intodi-sukharev:masterfrom
Conversation
di-sukharev
left a comment
di-sukharev
left a comment
There was a problem hiding this comment.
lets please move this duplicated code:
let content = message.content as string;
if (content && content.includes('<think>')) {
return content.replace(/<think>[\s\S]*?<\/think>/g, '').trim();
}
into a function and reuse it. it may accept tag: string argument, which should be think in each of the cases, but may vary i guess in different models
|
@kaovilai thank you for the contribution, could you follow up with my comment please <3 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>
di-sukharev
left a comment
di-sukharev
left a comment
There was a problem hiding this comment.
thank you for contribution <3
|
@kaovilai hi again, i think it broke the tests somehow https://github.com/di-sukharev/opencommit/actions/runs/14440831852/job/40490512204 could you please take a look? |
|
maybe.. worst case revert :D |
|
@kaovilai yeah :), i just dont want to revert your contribution, its necessary. hope you have time, i dont think its something wrong with the code itself, looks like a dependency is missing |
|
https://github.com/di-sukharev/opencommit/actions/workflows/test.yml weird.. same test ran in pr fine |
2 participants
No description provided.