Skip to content

Add fzf feature#110

Merged
sebst merged 4 commits intomainfrom
copilot/add-fzf-feature
Mar 19, 2026
Merged

Add fzf feature#110
sebst merged 4 commits intomainfrom
copilot/add-fzf-feature

Conversation

Copy link
Contributor

Copilot AI commented Mar 19, 2026

Adds the fzf fuzzy finder as a devcontainer feature, building on the implementation proposed in #104.

New files

  • src/fzf/devcontainer-feature.json — feature manifest with a version option (default: latest)
  • src/fzf/install.sh — downloads fzf from junegunn/fzf GitHub releases; resolves latest or pinned semver, maps Debian arch to the fzf release arch naming (amd64, arm64, armv7, 386), extracts the binary to /usr/local/bin
  • test/fzf/test.sh — verifies fzf --version succeeds

CI

Added fzf to both test-autogenerated and test-scenarios matrices in .github/workflows/test.yaml.

Original prompt

This section details on the original issue you should resolve

<issue_title>Add fzf feature</issue_title>
<issue_description>build on implementation in #104 </issue_description>

Comments on the Issue (you are @copilot in this section)


💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

Co-authored-by: sebst <592313+sebst@users.noreply.github.com>
Copilot AI changed the title [WIP] Add fzf feature based on previous implementation Add fzf feature Mar 19, 2026
Copilot AI requested a review from sebst March 19, 2026 09:28
@sebst sebst marked this pull request as ready for review March 19, 2026 09:28
Copy link
Member

@sebst sebst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests fail

…able conflict

Co-authored-by: sebst <592313+sebst@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 19, 2026

tests fail

Fixed in 180f0e7. Two issues were causing the test-autogenerated jobs to fail:

  1. Test check: fzf --version | grep 'fzf' was failing because recent fzf versions (v0.60+) output just the version number like 0.70.0 (unknown) without a "fzf" prefix. Changed to fzf --version.

  2. Install script warning: local: version: readonly variable in github_get_tag_for_version()set -o allexport causes the outer readonly version to be inherited by the $(...) subshell, conflicting with the local version parameter. Renamed to _version to avoid the collision.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/junegunn/fzf/releases/latest
    • Triggering command: /usr/bin/curl curl -s REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI requested a review from sebst March 19, 2026 09:52
@sebst sebst merged commit abb2006 into main Mar 19, 2026
1 check passed
@sebst sebst deleted the copilot/add-fzf-feature branch March 19, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add fzf feature

2 participants