Add keyword to allow disabling config forwarding in SSHCluster#8994
Open
jacobtomlinson wants to merge 1 commit intodask:mainfrom
Open
Add keyword to allow disabling config forwarding in SSHCluster#8994jacobtomlinson wants to merge 1 commit intodask:mainfrom
jacobtomlinson wants to merge 1 commit intodask:mainfrom
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ±0 27 suites ±0 11h 40m 27s ⏱️ + 6m 21s For more details on these failures, see this check. Results for commit 76d63b1. ± Comparison against base commit 49f5e74. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8138
#8138 shows that in Windows there is a limit to environment variable size, and
SSHClusterserialises your Dask config to forward to the remote processes. If your Dask config is really big then this will fail. There isn't a clear solution here, in #4465 we explored compressing config, but that isn't a perfect solution so hasn't been merged.A reasonable workaround is to be able to just disable this functionality if you don't need it. Users in #8138 (comment) have reported just modifying
distributedto disable this. This PR adds a kwarg to officially support disabling config forwarding.pre-commit run --all-files