Fix: Incorrect asset_properties for Identical Skins#376
Merged
Conversation
Step7750
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where multiple items of the same skin receive the same
asset_propertiesin the inventory item grid.The bug:
Fixed:
Note
Low Risk
Low risk: small, localized change to inventory metadata mapping that only affects how item properties are read/populated for display.
Overview
Fixes incorrect
asset_propertiesassignment for inventory items with identical skins by tightening how properties are populated inInventoryItemHolderMetadata.asset.For appwide inventories, it now copies from
invAsset.asset_propertieswhen present; for non-appwide inventories, it now prefersg_ActiveInventory.m_rgAssetProperties[this.assetId]instead of relying on the existing description field, preventing cross-item property reuse.Written by Cursor Bugbot for commit e92f863. Configure here.