Conversation
There was a problem hiding this comment.
Pull request overview
This PR bumps vscode-web to version 1.109.5 and updates several patched VS Code sources to align behavior/UI with the new upstream version.
Changes:
- Update
.VERSIONand refreshscripts/.patchhashes for the patched upstream files. - Preserve indentation options and EOL when performing Save As between text models.
- Add/adjust workbench UI/services: agent sessions workspace label, titlebar command center border radius, new
vscode-browserschema, and early workbench mode service initialization.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
vscode-web/src/vs/workbench/services/textfile/browser/textFileService.ts |
Copies indentation options + EOL from source model during Save As. |
vscode-web/src/vs/workbench/services/label/common/labelService.ts |
Adds a special-case label for agent sessions workspaces. |
vscode-web/src/vs/workbench/browser/web.main.ts |
Switches DefaultAccountService import target and initializes a WorkbenchModeService during service setup. |
vscode-web/src/vs/workbench/browser/parts/titlebar/media/titlebarpart.css |
Tweaks command center border radius styling. |
vscode-web/src/vs/base/common/network.ts |
Introduces Schemas.vscodeBrowser. |
vscode-web/scripts/.patch |
Updates hash manifest entries for patched files. |
vscode-web/.VERSION |
Bumps version to 1.109.5. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1 +1 @@ | |||
| 1.108.2 No newline at end of file | |||
| 1.109.5 No newline at end of file | |||
There was a problem hiding this comment.
The PR title/description says this is only a version bump, but this change set also modifies runtime behavior and UI (e.g., text model option copying, workspace label, new service registration, CSS). Please update the PR title/description (or split into separate PRs) so the scope is accurately represented for reviewers and release notes.
| // Layout Mode | ||
| const workbenchModeService: WorkbenchModeService = this._register(new WorkbenchModeService(configurationService, fileService, environmentService, uriIdentityService, logService, storageService)); | ||
| serviceCollection.set(IWorkbenchModeService, workbenchModeService); | ||
| try { | ||
| await workbenchModeService.initialize(); | ||
| } catch (error) { | ||
| logService.error('Error while initializing workbench mode service', error); | ||
| } |
There was a problem hiding this comment.
This adds a new service registration/initialization inside a section that explicitly warns not to register services here (see the NOTE immediately above). To follow the intended architecture and avoid duplicate instances / ordering issues, move this to the appropriate registerSingleton() location (e.g. workbench.web.main.ts for web-only services) and keep BrowserMain.initServices() focused on wiring core boot services.
Bump the version number to 1.109.5