-
Notifications
You must be signed in to change notification settings - Fork 4.1k
fix: enable useLegacyCompletionsEndpoint to use openai package streaming
#10026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 4 files
RomneyDa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uinstinct since stream is already in completion options, how does this impact functionality? I think we should avoid adding a duplicate configuration option.
- already completionoptions.stream is present
91a97d2 to
ac5b8dc
Compare
useLegacyCompletionsEndpoint to use openai package streaming
My bad - I thought since completionOptions.stream was removed from config.yaml reference doc, support was dropped. Added that back to the config.yaml reference in docs |
RomneyDa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uinstinct could you clarify how useLegacyCompletionsEndpoint and stream are related? As far as I understand useLegacyCompletionsEndpoint is for using a different URL endpoint /completions which was used prior to chat/completions coming out. stream is the issue here (you can use chat/completions with stream = false)
|
openai models (which require org verifications) cannot use the responses endpoint - so when |
|
@uinstinct the legacy completions endpoint is the ancient But I don't think we need to fallback to that either, I think they can use responses, they just can't stream it. Kilo code fixed this by adding a stream toggle, I don't think they routed to a different endpoint. I think the issue is that I think a stream toggle (which only shows when error detected) is a decent solution, as long as the |
It seems we will have to use the I investigated kilocode now and found that they are using Currently we support using /completions endpoint via config.yaml. Should we also add support for /chat/completions via config.yaml? |
Description
Add supports for
useLegacyCompletionsEndpointto use openai adapter streaming.closes CON-5285
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Continue Tasks:▶️ 1 queued · ✅ 1 no changes — View all
Summary by cubic
Disables streaming for OpenAI o-series/GPT-5 when the legacy completions endpoint is used, aligning behavior with model constraints. Addresses CON-5285.
Written for commit be39317. Summary will update on new commits.