Handle missing SIGHUP on Windows #22

Copilot · 2026-01-16T09:53:03Z

Plan to Handle Missing SIGHUP on Windows

Original prompt

This section details on the original issue you should resolve

<issue_title>Handle missing SIGHUP on Windows</issue_title>
<issue_description>SIGHUP is not present on Windows, so the crontask management command crashes with AttributeError: module 'signal' has no attribute 'SIGHUP'.

If I change these lines in crontask.py:
def launch_scheduler(self, lock, scheduler):
    signal.signal(signal.SIGHUP, kill_softly)
To this:
def launch_scheduler(self, lock, scheduler):
    if hasattr(signal, "SIGHUP"):
        signal.signal(signal.SIGHUP, kill_softly)
Then it works on Windows, and CTRL-C sends SIGINT and stops the worker as expected.</issue_description>

<agent_instructions>
I would avoid the if-branch in favor of EAFP.
We should also see if there is an alternative implementation in Windows; if so, conditional branches could be based on the OS with a match-case statement.

Make sure to check if there are pypi classifiers, that could be added for windows or macos, or other that are matching. Please extend the CI suite to run against windows and macos.</agent_instructions>

Comments on the Issue (you are @copilot in this section)
@codingjoe Hi @rtr1 👋,
Thanks for reaching out! I see; I haven't tested this on Windows yet. We should add Windows and macOS to the CI suite too.

I'll let my robot-buddy have a shot at this!

Thanks!
Joe</comment_new>

Fixes Handle missing SIGHUP on Windows #21

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

- Use EAFP pattern with try/except for signal handling - Add Windows-specific SIGBREAK signal support - Use match-case for OS-specific signal registration - Add comprehensive tests for signal handling across platforms - Update pyproject.toml with Windows/macOS classifiers - Extend CI to run on Windows and macOS Co-authored-by: codingjoe <[email protected]>

Remove conflicting 'OS Independent' classifier and use more general 'POSIX' instead of 'POSIX :: Linux' to better reflect actual OS support. Co-authored-by: codingjoe <[email protected]>

Add explicit permissions block to limit GITHUB_TOKEN permissions as a security best practice. Co-authored-by: codingjoe <[email protected]>

codecov · 2026-01-16T10:30:11Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.59%. Comparing base (08c90d2) to head (0c4b29e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   98.54%   98.59%   +0.05%     
==========================================
  Files           5        5              
  Lines         137      142       +5     
==========================================
+ Hits          135      140       +5     
  Misses          2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codingjoe

@copilot ditch the comments. The code is pretty easy to read.

.github/workflows/ci.yml

crontask/management/commands/crontask.py

- Remove all comments from signal handling code - Simplify pytest-windows-macos to test only Django 5.2 LTS and Python 3.13 Co-authored-by: codingjoe <[email protected]>

Copilot · 2026-01-16T11:10:40Z

@copilot ditch the comments. The code is pretty easy to read.

Removed all comments in a4b314c

codingjoe

LGTM

Copilot

Pull request overview

This pull request addresses the missing SIGHUP signal on Windows by implementing platform-specific signal handling in the crontask management command. The solution uses Python's match-case statement to register different signals based on the operating system, with graceful error handling for signals that may not be available.

Changes:

Implemented platform-aware signal registration with EAFP pattern for unavailable signals
Added comprehensive test coverage for signal handling on different platforms
Extended CI pipeline to test on Windows and macOS in addition to Linux
Updated pyproject.toml classifiers to reflect multi-platform support

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

File	Description
crontask/management/commands/crontask.py	Added platform detection and platform-specific signal registration (SIGBREAK for Windows, SIGHUP for Unix-like systems) with graceful error handling
tests/test_commands.py	Added three new test methods to verify signal registration behavior on Unix, Windows, and when signals are unavailable
pyproject.toml	Updated OS classifiers from "OS Independent" to specific platform classifiers for Windows, macOS, and POSIX
.github/workflows/ci.yml	Split pytest job and added new job for Windows and macOS testing with Python 3.13 and Django 6.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-16T11:26:45Z

pyproject.toml

  "Intended Audience :: Developers",
-  "Operating System :: OS Independent",
+  "Operating System :: Microsoft :: Windows",
+  "Operating System :: MacOS",


The classifier "Operating System :: MacOS" is not valid. The correct PyPI classifier is "Operating System :: MacOS :: MacOS X" according to the official PyPI classifier list.

Update this to use the correct classifier format.

Suggested change

"Operating System :: MacOS",

"Operating System :: MacOS :: MacOS X",

Fixed in 4078eee

Copilot · 2026-01-16T11:26:46Z

tests/test_commands.py

+        # Mock signal.signal to raise AttributeError for SIGHUP
+        original_signal = signal.signal
+
+        def mock_signal(signum, handler):
+            # Simulate SIGHUP not being available
+            if hasattr(signal, "SIGHUP") and signum == signal.SIGHUP:
+                raise AttributeError("SIGHUP not available")
+            return original_signal(signum, handler)
+
+        with patch("signal.signal", side_effect=mock_signal):
+            with io.StringIO() as stdout:
+                # Should not raise an exception
+                call_command("crontask", stdout=stdout)
+                assert "Starting scheduler…" in stdout.getvalue()


This test doesn't effectively verify the platform-specific signal handling behavior. The test mocks signal.signal to raise AttributeError when registering SIGHUP, but the actual implementation in crontask.py uses a match statement on sys.platform to determine which signals to register. The test doesn't mock sys.platform, so it will execute the default branch (non-Windows) which tries to register SIGHUP.

However, the mock on line 143-147 checks if hasattr(signal, "SIGHUP") which will be True on Unix systems (where tests typically run), causing it to raise an error. But this doesn't match the real scenario where SIGHUP simply doesn't exist as an attribute on Windows. Consider restructuring this test to more accurately simulate the Windows environment by mocking both sys.platform and removing the SIGHUP attribute from the signal module.

Suggested change

# Mock signal.signal to raise AttributeError for SIGHUP

original_signal = signal.signal

def mock_signal(signum, handler):

# Simulate SIGHUP not being available

if hasattr(signal, "SIGHUP") and signum == signal.SIGHUP:

raise AttributeError("SIGHUP not available")

return original_signal(signum, handler)

with patch("signal.signal", side_effect=mock_signal):

with io.StringIO() as stdout:

# Should not raise an exception

call_command("crontask", stdout=stdout)

assert "Starting scheduler…" in stdout.getvalue()

# Simulate a platform where SIGHUP is not defined (e.g. Windows)

with patch.object(sys, "platform", "win32"):

had_sighup = hasattr(signal, "SIGHUP")

original_sighup = getattr(signal, "SIGHUP", None)

if had_sighup:

delattr(signal, "SIGHUP")

try:

with io.StringIO() as stdout:

# Should not raise an exception even if SIGHUP is missing

call_command("crontask", stdout=stdout)

assert "Starting scheduler…" in stdout.getvalue()

finally:

# Restore SIGHUP attribute for other tests

if had_sighup:

setattr(signal, "SIGHUP", original_sighup)

Replaced with simpler OS-specific tests using @pytest.mark.skipif in 4078eee

Copilot · 2026-01-16T11:26:46Z

.github/workflows/ci.yml

+  pytest-windows-macos:
+    name: Pytest
+    permissions:
+      contents: read
+    strategy:
+      matrix:
+        os:
+          - "windows-latest"
+          - "macos-latest"
+        python-version:
+          - "3.13"
+        django-version:
+          - "6.0"
+    runs-on: ${{ matrix.os }}
+    steps:
+      - uses: actions/checkout@v6
+      - uses: astral-sh/setup-uv@v7
+        with:
+          python-version: ${{ matrix.python-version }}
+      - run: uv run --with django~=${{ matrix.django-version }}.0 pytest


The Windows/macOS pytest job doesn't set the REDIS_URL environment variable that is set for the Linux job (line 41). While tests that require Redis are already using pytest.importorskip to skip when Redis is not available, this inconsistency could lead to confusion or unexpected behavior if any code checks for the REDIS_URL environment variable.

Consider either adding the REDIS_URL environment variable to this job (even though Redis service isn't configured), or documenting why it's not needed for these platforms.

Copilot · 2026-01-16T11:26:46Z

crontask/management/commands/crontask.py

+                signal.signal(signal.SIGTERM, kill_softly)
+                signal.signal(signal.SIGINT, kill_softly)
+            case _:
+                try:
+                    signal.signal(signal.SIGHUP, kill_softly)
+                except (AttributeError, OSError):
+                    pass
+                signal.signal(signal.SIGTERM, kill_softly)
+                signal.signal(signal.SIGINT, kill_softly)


The signal registration code is duplicated in both branches of the match statement. SIGTERM and SIGINT are registered identically in lines 70-71 and 77-78. This duplication reduces maintainability and increases the risk of inconsistencies.

Consider refactoring to eliminate duplication by registering the platform-specific signals first (SIGHUP for non-Windows, SIGBREAK for Windows), then registering SIGTERM and SIGINT once after the match statement.

Suggested change

signal.signal(signal.SIGTERM, kill_softly)

signal.signal(signal.SIGINT, kill_softly)

case _:

try:

signal.signal(signal.SIGHUP, kill_softly)

except (AttributeError, OSError):

pass

signal.signal(signal.SIGTERM, kill_softly)

signal.signal(signal.SIGINT, kill_softly)

case _:

try:

signal.signal(signal.SIGHUP, kill_softly)

except (AttributeError, OSError):

pass

signal.signal(signal.SIGTERM, kill_softly)

signal.signal(signal.SIGINT, kill_softly)

Fixed duplication - moved SIGTERM and SIGINT outside match block in 4078eee

Copilot · 2026-01-16T11:26:47Z

crontask/management/commands/crontask.py

+            case "win32":
+                try:
+                    signal.signal(signal.SIGBREAK, kill_softly)
+                except (AttributeError, OSError):


'except' clause does nothing but pass and there is no explanatory comment.

I'd be good to know when this exception is expected, and why an OSError?

Removed OSError - only AttributeError is expected when a signal constant doesn't exist on a platform (e.g., SIGHUP on Windows). Fixed in 4078eee

Copilot · 2026-01-16T11:26:47Z

crontask/management/commands/crontask.py

+            case _:
+                try:
+                    signal.signal(signal.SIGHUP, kill_softly)
+                except (AttributeError, OSError):


'except' clause does nothing but pass and there is no explanatory comment.

We need an example, where this could fail.

Removed OSError - only AttributeError is expected when signal.SIGHUP doesn't exist as an attribute on the platform. Fixed in 4078eee

codingjoe · 2026-01-16T11:33:16Z

@copilot address the unresolved review comments. Furthermore, try to avoid patching and mocking where possible. You may also use OS-dependent tests via @pytest.mark.skipif(sys.platform == ...

- Remove code duplication: move SIGTERM/SIGINT registration outside match block - Remove OSError from exception handling (only AttributeError is expected) - Fix PyPI classifier: "Operating System :: MacOS" -> "Operating System :: MacOS :: MacOS X" - Simplify tests: use @pytest.mark.skipif for OS-specific tests instead of mocking sys.platform - Remove ineffective test_launch_scheduler_missing_sighup test Co-authored-by: codingjoe <[email protected]>

Copilot · 2026-01-16T11:36:40Z

@copilot address the unresolved review comments. Furthermore, try to avoid patching and mocking where possible. You may also use OS-dependent tests via @pytest.mark.skipif(sys.platform == ...

Addressed all review comments in 4078eee:

Removed code duplication
Simplified exception handling to only catch AttributeError
Rewrote tests using @pytest.mark.skipif for OS-specific testing without mocking
Fixed PyPI classifier

codingjoe · 2026-01-16T13:16:42Z

pre-commit.ci run

for more information, see https://pre-commit.ci

Initial plan

06a4b83

Copilot AI assigned Copilot and codingjoe Jan 16, 2026

Copilot started work on behalf of codingjoe January 16, 2026 09:53 View session

Copilot AI and others added 3 commits January 16, 2026 09:58

Fix pyproject.toml classifiers: remove OS Independent

5ed0a9f

Remove conflicting 'OS Independent' classifier and use more general 'POSIX' instead of 'POSIX :: Linux' to better reflect actual OS support. Co-authored-by: codingjoe <[email protected]>

Add workflow permissions to pytest-windows-macos job

e232939

Add explicit permissions block to limit GITHUB_TOKEN permissions as a security best practice. Co-authored-by: codingjoe <[email protected]>

Copilot AI changed the title ~~[WIP] Fix missing SIGHUP handling for Windows in crontask~~ Handle missing SIGHUP on Windows Jan 16, 2026

Copilot AI requested a review from codingjoe January 16, 2026 10:04

Copilot finished work on behalf of codingjoe January 16, 2026 10:04

codingjoe reviewed Jan 16, 2026

View reviewed changes

.github/workflows/ci.yml Show resolved Hide resolved

crontask/management/commands/crontask.py Outdated Show resolved Hide resolved

Copilot started work on behalf of codingjoe January 16, 2026 11:08 View session

Remove code comments and simplify CI matrix

a4b314c

- Remove all comments from signal handling code - Simplify pytest-windows-macos to test only Django 5.2 LTS and Python 3.13 Co-authored-by: codingjoe <[email protected]>

Copilot AI requested a review from codingjoe January 16, 2026 11:11

Copilot finished work on behalf of codingjoe January 16, 2026 11:11

Update ci

0675ca3

codingjoe reviewed Jan 16, 2026

View reviewed changes

codingjoe added 3 commits January 16, 2026 12:17

Add a name

16025bd

Fix django version

a2204da

fix syntax

6b0cbfd

codingjoe marked this pull request as ready for review January 16, 2026 11:22

Copilot AI review requested due to automatic review settings January 16, 2026 11:22

Copilot started reviewing on behalf of codingjoe January 16, 2026 11:22 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

Copilot started work on behalf of codingjoe January 16, 2026 11:33 View session

Copilot finished work on behalf of codingjoe January 16, 2026 11:37

Copilot AI requested a review from codingjoe January 16, 2026 11:37

pre-commit-ci bot and others added 2 commits January 16, 2026 13:18

[pre-commit.ci] auto fixes from pre-commit.com hooks

3e7ebe7

for more information, see https://pre-commit.ci

Drop unavailable branches

0c4b29e

codingjoe merged commit 03b8d0b into main Jan 16, 2026
15 checks passed

codingjoe deleted the copilot/fix-sighup-windows-issue branch January 16, 2026 13:24

	"Operating System :: MacOS",
	"Operating System :: MacOS :: MacOS X",

Uh oh!

Handle missing SIGHUP on Windows #22

Handle missing SIGHUP on Windows #22

Uh oh!

Conversation

Copilot AI commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Plan to Handle Missing SIGHUP on Windows

Comments on the Issue (you are @copilot in this section)

Uh oh!

codecov bot commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codingjoe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Jan 16, 2026

Uh oh!

codingjoe left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

codingjoe Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

codingjoe Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

codingjoe commented Jan 16, 2026

Uh oh!

Copilot AI commented Jan 16, 2026

Uh oh!

codingjoe commented Jan 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Copilot AI commented Jan 16, 2026 •

edited

Loading

codecov bot commented Jan 16, 2026 •

edited

Loading