[SANDBOX-1700] chore: upgrade to OCP 4.21 dependencies#501
[SANDBOX-1700] chore: upgrade to OCP 4.21 dependencies#501metlos wants to merge 1 commit intocodeready-toolchain:masterfrom
Conversation
Update openshift/api to release-4.21, k8s.io deps to v0.34.1, controller-runtime to v0.22.0, and controller-tools to v0.19.0. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
WalkthroughUpdated Go module dependencies in go.mod, including core packages like Kubernetes API/machinery to v0.34.1, OpenShift API, code-generator, kube-openapi, controller-runtime, and various x/ modules, along with indirect dependencies like protobuf, YAML, and structured-merge-diff. No functional code changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can disable sequence diagrams in the walkthrough.Disable the |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
go.mod (1)
3-5:⚠️ Potential issue | 🟡 MinorDocument the toolchain version intent if it diverges from CI expectations.
The
go 1.24.4declaration will be used by CI workflows (actions/setup-goreads thegodirective), while thetoolchain go1.24.13suggestion only applies locally if toolchain auto-selection is enabled. This creates a potential build environment inconsistency: developers may build and test with Go 1.24.13 while CI validates with Go 1.24.4. If this is intentional for reproducibility/standardization, document it; if unintentional, align the versions.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@go.mod` around lines 3 - 5, The go.mod declares "go 1.24.4" while the toolchain line is "toolchain go1.24.13", causing CI vs local toolchain mismatch; either make them identical (update "go 1.24.4" to "go 1.24.13" or change "toolchain go1.24.13" to match 1.24.4) or add a short comment in the repo README or a new TOOLCHAIN.md explaining the intentional divergence and which version CI (go directive) and local toolchain (toolchain directive) should use; update the go.mod and documentation consistently and mention the authoritative source (CI uses the go directive).
🧹 Nitpick comments (1)
go.mod (1)
9-10: Update the OpenShift branch comment to match the actual upgrade target.The inline comment says
release-4.20while this PR upgrades to OCP 4.21 and bumpsgithub.com/openshift/apiaccordingly. Keeping this stale comment will mislead future dependency updates.As per coding guidelines, "Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@go.mod` around lines 9 - 10, Update the inline comment above the github.com/openshift/api dependency in go.mod so it reflects the actual target branch release-4.21 (instead of stale release-4.20) to match the bumped dependency version; locate the comment near the github.com/openshift/api v0.0.0-20260304172252-b0658d22beea entry and change the branch name text to release-4.21.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@go.mod`:
- Around line 3-5: The go.mod declares "go 1.24.4" while the toolchain line is
"toolchain go1.24.13", causing CI vs local toolchain mismatch; either make them
identical (update "go 1.24.4" to "go 1.24.13" or change "toolchain go1.24.13" to
match 1.24.4) or add a short comment in the repo README or a new TOOLCHAIN.md
explaining the intentional divergence and which version CI (go directive) and
local toolchain (toolchain directive) should use; update the go.mod and
documentation consistently and mention the authoritative source (CI uses the go
directive).
---
Nitpick comments:
In `@go.mod`:
- Around line 9-10: Update the inline comment above the github.com/openshift/api
dependency in go.mod so it reflects the actual target branch release-4.21
(instead of stale release-4.20) to match the bumped dependency version; locate
the comment near the github.com/openshift/api v0.0.0-20260304172252-b0658d22beea
entry and change the branch name text to release-4.21.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d0eebf58-f13f-4c9d-95ae-d5753bc60056
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
2 participants
Update openshift/api to release-4.21, k8s.io deps to v0.34.1, controller-runtime to v0.22.0, and controller-tools to v0.19.0.
https://redhat.atlassian.net/browse/SANDBOX-1700
Checks
Did you run
make generatetarget? noThis would only change
controller-gen.kubebuilder.io/versionannotation to from0.18.0to0.19.0. No actual changes to the CRDs.Did
make generatechange anything in other projects (host-operator, member-operator)? noSee above
Summary by CodeRabbit