feat: support for AVIF images#10023
Closed
JulianAtkins wants to merge 6 commits intocodeigniter4:4.8from
Closed
Conversation
…od (codeigniter4#10019) * docs: add none parameter example to the query builder like method * align code comment
…#10016) * refactor: fix phpstan no type specified UpdateModelTest * use native php type * use DateTimeInterface type
…igniter4#10020) * fix: Fixed CreateNewChangelogTest * fix: Update warning in test
Member
|
Please target the 4.8 branch: Your commits have to be signed: Run this to fix your code style: |
Contributor
Author
|
Sorry about that, I did not know about the 4.8 branch, I've changed it now. I'm looking at the signed commits thing, but it looks very time consuming. Last year I created a pull request for the codeigniter |
Contributor
Author
|
I'll close this pull request and re-do it with signed commits under the 4.8 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I added support for the AVIF image files. AVIF was implemented in PHP 8.1 which suitable now that codeigniter requires PHP 8.2. AVIF became a globally supported format around 2024, available across all major browsers (chrome, edge, safari, firefox, opera).
The only interesting thing in the code, is that the save() function has one additional parameter for the speed (-1 by default as is the PHP default as well).
Checklist: