Skip to content

Update test environment to fix tests on legacy PHP 7.2 with PHPUnit 8.5#180

Merged
clue merged 1 commit intoclue:3.xfrom
clue-labs:phpunit8
Feb 15, 2026
Merged

Update test environment to fix tests on legacy PHP 7.2 with PHPUnit 8.5#180
clue merged 1 commit intoclue:3.xfrom
clue-labs:phpunit8

Conversation

@clue
Copy link
Owner

@clue clue commented Feb 15, 2026

This changeset updates the test environment to fix tests on legacy PHP 7.2 with PHPUnit 8.5. This is needed to run the tests on legacy platforms due to recent upstream changes:

  • A recent security advisory (GHSA-vvj3-c3rp-c85p) affects most PHPUnit versions. It was patched in actively supported releases, but not in legacy PHPUnit versions, which we rely on for tests on legacy PHP < 7.3.
  • Composer 2.9 now blocks installing packages with known advisories by default (Composer update: filter packages with security advisories from pool composer/composer#11956). Legacy PHP < 7.2 uses older Composer versions.
  • While this project should not be affected by the advisory, both things combined mean that Composer would fail on legacy PHP 7.2 only ("Your requirements could not be resolved to an installable set of packages.")
  • The suggested changes allow using PHPUnit 8.5 on PHP 7.2 until we remove legacy platforms in the future.

Builds on top of #104 and #127 and others

@clue clue added this to the v3.0.0 milestone Feb 15, 2026
@clue clue requested a review from Copilot February 15, 2026 01:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates dependency constraints and CI invocation to allow running the test suite on legacy PHP versions by permitting PHPUnit 8.5 and selecting the legacy PHPUnit config when needed.

Changes:

  • Allow installing phpunit/phpunit ^8.5 in require-dev to support legacy PHP environments.
  • Simplify the CI PHPUnit step by inlining the conditional selection of phpunit.xml.legacy for older PHP versions.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
composer.json Expands PHPUnit version constraints to include ^8.5 for legacy PHP compatibility.
.github/workflows/ci.yml Consolidates PHPUnit run steps into one command with conditional legacy config selection.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@clue clue changed the title Update test environment to fix tests on legacy PHP 7.3 with PHPUnit 8.5 Update test environment to fix tests on legacy PHP 7.2 with PHPUnit 8.5 Feb 15, 2026
@clue clue merged commit e928901 into clue:3.x Feb 15, 2026
26 checks passed
@clue clue deleted the phpunit8 branch February 15, 2026 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant