Update test environment to fix tests on legacy PHP 7.2 with PHPUnit 8.5#180
Merged
Update test environment to fix tests on legacy PHP 7.2 with PHPUnit 8.5#180
Conversation
There was a problem hiding this comment.
Pull request overview
Updates dependency constraints and CI invocation to allow running the test suite on legacy PHP versions by permitting PHPUnit 8.5 and selecting the legacy PHPUnit config when needed.
Changes:
- Allow installing
phpunit/phpunit^8.5inrequire-devto support legacy PHP environments. - Simplify the CI PHPUnit step by inlining the conditional selection of
phpunit.xml.legacyfor older PHP versions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| composer.json | Expands PHPUnit version constraints to include ^8.5 for legacy PHP compatibility. |
| .github/workflows/ci.yml | Consolidates PHPUnit run steps into one command with conditional legacy config selection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset updates the test environment to fix tests on legacy PHP 7.2 with PHPUnit 8.5. This is needed to run the tests on legacy platforms due to recent upstream changes:
Builds on top of #104 and #127 and others