Open
Conversation
evanfarrar
approved these changes
Mar 31, 2026
johha
reviewed
Apr 1, 2026
| module Diego | ||
| class TasksSync | ||
| BATCH_SIZE = 500 | ||
| PENDING_TASK_EXPIRATION = 300 |
Contributor
There was a problem hiding this comment.
Could you add a unit to the constant name?
Also does it make sense to make this configurable with a default of 300s?
Member
Author
There was a problem hiding this comment.
I don't think there is a big benefit to making this configurable.
sethboyles
force-pushed
the
fail_pending_tasks
branch
from
97adc6b to
9965116
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR started counting PENDING tasks towards quotas: #4651
This has revealed a number of tasks stuck in PENDING that are incorrectly inflating orgs' memory usage.
I haven't traced the cause for all of the stuck tasks yet, but I believe it probably happened when trying to save the state right after a Diego submission--I think it could have happened if there was a DB availability issue, for example. Regardless, these PENDING tasks will never get updated if they hit this state.
This PR transitions them to FAILED after a short period.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests