Support post data on PATCH requests in OAuth2#314
Open
jankeromnes wants to merge 1 commit intociaranj:masterfrom
Open
Support post data on PATCH requests in OAuth2#314jankeromnes wants to merge 1 commit intociaranj:masterfrom
jankeromnes wants to merge 1 commit intociaranj:masterfrom
Conversation
satori-stan
approved these changes
Oct 10, 2016
satori-stan
left a comment
There was a problem hiding this comment.
Agree on this change. There is a previous request requesting the same (with different method). Any one would do. Both could add DELETE method to the list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some OAuth2-enabled APIs use the
PATCHHTTP verb (for example GitHub's API) combined with a body to update an existing resource.This one-line change makes it possible to use
oauth2's_requestcall to send aPATCHrequest with such a body. @ciaranj please take a look.