fix to use https proxy agent, when https_proxy env variable is set.#294
Open
gstroup wants to merge 1 commit intociaranj:masterfrom
Open
fix to use https proxy agent, when https_proxy env variable is set.#294gstroup wants to merge 1 commit intociaranj:masterfrom
gstroup wants to merge 1 commit intociaranj:masterfrom
Conversation
|
I have dealing with proxy issues at my job. I found a similar solution. Where this will be merge? |
|
As many corporate infrastructure has http proxy in place, it is good idea to honor these environment variables Is the merge conflict a reason for not getting this PR merged? If yes, I am happy to help resolving and considering all the above variables covered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.