feat: fireEvent.press/scroll default event object#1884
Open
mdjastrzebski wants to merge 10 commits intomainfrom
Open
feat: fireEvent.press/scroll default event object#1884mdjastrzebski wants to merge 10 commits intomainfrom
mdjastrzebski wants to merge 10 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1884 +/- ##
==========================================
+ Coverage 98.28% 98.30% +0.01%
==========================================
Files 80 79 -1
Lines 1459 1475 +16
Branches 381 408 +27
==========================================
+ Hits 1434 1450 +16
Misses 24 24
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promote
event-buildermodule fromuser-event/event-builderto a top-levelsrc/event-buildermodule and use it infireEventto provide proper event objects.Changes
event-buildertosrc/event-builder/: Relocated fromsrc/user-event/event-builder/so it can be shared across bothfireEventanduserEventAPIs.EventBuilder.Common.*/EventBuilder.TextInput.*/EventBuilder.ScrollView.*pattern with flat, named function exports (e.g.,buildTouchEvent(),buildScrollEvent(),buildTextChangeEvent()).fireEvent.pressandfireEvent.scroll: These now automatically construct proper event objects (touch event for press, scroll event for scroll) instead of passing raw user data. Custom event props are deep-merged into the default event structure.TextRangeintosrc/types.tsalongsidePointandSize(removingsrc/user-event/utils/text-range.ts).userEventconsumers: Migrate all imports from the oldEventBuildernamespace to the new flat exports.