Auto-generate foreign key constraint names when not provided#1041
Open
dereuromark wants to merge 4 commits into5.xfrom
Open
Auto-generate foreign key constraint names when not provided#1041dereuromark wants to merge 4 commits into5.xfrom
dereuromark wants to merge 4 commits into5.xfrom
Conversation
dereuromark
force-pushed
the
fix-auto-generate-fk-constraint-name
branch
2 times, most recently
from
c582b85 to
809abc9
Compare
When a foreign key is added without an explicit name, the MysqlAdapter and SqliteAdapter now generate a name following the pattern 'tablename_columnname' (e.g., 'articles_user_id' for a FK on the user_id column in the articles table). This matches the behavior of PostgresAdapter and SqlserverAdapter, which already auto-generate FK names. This ensures constraint names are always strings and prevents issues with constraint lookup methods that expect string names.
Update the expected FK names in comparison files and schema dumps to match the new auto-generated naming pattern (tablename_columnname).
dereuromark
force-pushed
the
fix-auto-generate-fk-constraint-name
branch
from
ed2b2d3 to
629c85e
Compare
The FK constraint name change from auto-generated (ibfk_N) to explicit (table_column) also affects the implicit index MySQL creates for FKs. Update comparison files to reflect the index rename from user_id to articles_user_id.
With the FK naming changes, both the lock file and database have the index named articles_user_id, so no diff is needed for this index. Remove the index rename operations that were incorrectly added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
addForeignKey(){table}_{columns}(matching PostgresAdapter and SqlserverAdapter behavior)This fixes an issue where unnamed constraints could cause problems with CakePHP's
ConnectionHelper::dropTables()which expects string constraint names. When no name was provided, MySQL would auto-generate one, but the schema reflection could store it with integer array keys, causingTypeErrorinTableSchema::getConstraint().Fixes #1040