fix(environ): repair unsound StringPool::try_clone()#12906
Open
flavio wants to merge 1 commit intobytecodealliance:mainfrom
Open
fix(environ): repair unsound StringPool::try_clone()#12906flavio wants to merge 1 commit intobytecodealliance:mainfrom
flavio wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
The 43.0 release introduced a soundness bug in StringPool::try_clone(): the cloned map retains &'static str keys pointing into the original pool's strings storage. Once the original Linker is dropped those keys dangle. Cloning a Linker, then dropping the original one, leaves a linker whose registered imports could no longer be found, causing instantiation to fail with "unknown import". Signed-off-by: Flavio Castelli <fcastelli@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #12905
The 43.0 release introduced a soundness bug in
StringPool::try_clone(): the cloned map retains&'static strkeys pointing into the original pool's strings storage. Once the originalLinkeris dropped those keys dangle.Cloning a
Linker, then dropping the original one, leaves a linker whose registered imports could no longer be found, causing instantiation to fail withunknown import.