Debugging: add debugger support for wasmtime serve.#12859
Queued
cfallin wants to merge 1 commit intobytecodealliance:mainfrom
Queued
Debugging: add debugger support for wasmtime serve.#12859cfallin wants to merge 1 commit intobytecodealliance:mainfrom
wasmtime serve.#12859cfallin wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
github-actions
bot
added
the
wasmtime:api
fitzgen
reviewed
Mar 30, 2026
Member
fitzgen
left a comment
fitzgen
left a comment
There was a problem hiding this comment.
LGTM -- maybe we should have newtypes for offset in code module, vs offset in component, vs offset in code section? Doesn't need to block this PR landing.
cfallin
force-pushed
the
debug-wasmtime-serve-2
branch
2 times, most recently
from
56e65ac to
3297c73
Compare
Member
Author
|
Good idea -- did the newtype thing and pulled out the underlying fixes from this PR as #12901; only last commit is the |
cfallin
force-pushed
the
debug-wasmtime-serve-2
branch
2 times, most recently
from
e7c9a35 to
9c766b3
Compare
This adopts a simple solution to bytecodealliance#12776: it takes the "instance reuse" paradigm to the extreme, instantiating exactly one instance and serializing all requests into that one instance. This allows the debugger component to operate on one `Store`, setting breakpoint state and presenting its execution to the attached debugger as a single program execution and minimizing impedance mismatches. This also adds an integration test that runs an existing wasi-http test component under the debugger.
cfallin
force-pushed
the
debug-wasmtime-serve-2
branch
from
9c766b3 to
d21bfc2
Compare
Member
Author
|
Rebased out the other fixes so now this is just |
Member
Author
|
(@fitzgen you had written "LGTM" above but no r+ -- fyi, but no rush) |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adopts a simple solution to #12776: it takes the "instance reuse" paradigm to the extreme, instantiating exactly one instance and serializing all requests into that one instance. This allows the debugger component to operate on one
Store, setting breakpoint state and presenting its execution to the attached debugger as a single program execution and minimizing impedance mismatches.This also adds an integration test that runs an existing wasi-http test component under the debugger.
Contains a few bugfixes to core debug functionality:
wasminto one, and gets confused about base addresses and module indices.With these fixes, setting a breakpoint at
handlein a wasi-http component and introspecting mid-request works properly.Closes #12776.