feat: migrate from wit-bindgen to go-pkg #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Steurer <[email protected]>
Signed-off-by: Andrew Steurer <[email protected]>
dicej
approved these changes
Feb 9, 2026
dicej
left a comment
dicej
left a comment
There was a problem hiding this comment.
Thanks, @asteurer. I'll admit I still don't know the rules governing go-import meta elements (and can't seem to find any official documentation about them), so my inline suggestions may or may not be relevant. I suppose we'll just need to test everything using go get to be sure we've got it right.
| <head> | ||
| <title>go.bytecodealliance.org/cmd</title> | ||
| <!-- Legacy: for now, the cmd package stays in go-modules --> | ||
| <meta name="go-import" content="go.bytecodealliance.org git https://github.com/bytecodealliance/go-modules" /> |
There was a problem hiding this comment.
Suggested change
| <meta name="go-import" content="go.bytecodealliance.org git https://github.com/bytecodealliance/go-modules" /> | |
| <meta name="go-import" content="go.bytecodealliance.org/cmd git https://github.com/bytecodealliance/go-modules" /> |
| <head> | ||
| <title>go.bytecodealliance.org/wit</title> | ||
| <!-- Legacy: wit package stays in go-modules --> | ||
| <meta name="go-import" content="go.bytecodealliance.org git https://github.com/bytecodealliance/go-modules" /> |
There was a problem hiding this comment.
Suggested change
| <meta name="go-import" content="go.bytecodealliance.org git https://github.com/bytecodealliance/go-modules" /> | |
| <meta name="go-import" content="go.bytecodealliance.org/wit git https://github.com/bytecodealliance/go-modules" /> |
| <head> | ||
| <title>go.bytecodealliance.org/x</title> | ||
| <!-- Legacy: for now, the x package stays in go-modules --> | ||
| <meta name="go-import" content="go.bytecodealliance.org git https://github.com/bytecodealliance/go-modules" /> |
There was a problem hiding this comment.
Suggested change
| <meta name="go-import" content="go.bytecodealliance.org git https://github.com/bytecodealliance/go-modules" /> | |
| <meta name="go-import" content="go.bytecodealliance.org/x git https://github.com/bytecodealliance/go-modules" /> |
| # Overview | ||
|
|
||
| Starter template for Bytecode Alliance repositories. | ||
| TODO |
There was a problem hiding this comment.
A sentence or two about why this repository exists could be a good start here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two commits:
22baf34shows the wit-bindgen packages as they are currently2a6ad2cshows the actual code changes required to migrate fromwit-bindgentogo-pkg.Hopefully this makes review a little easier.
Additionally, I have a working fork of wit-bindgen that has this commit checked in as a submodule.