fix: improve banner visibility on light terminal backgrounds #863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bee-san#778 The banner was hard to read on light terminal themes because it used bright green and yellow colors designed for dark backgrounds. Changes: - Add terminal-light crate to detect terminal background luminance - Add is_light_terminal() to detect light vs dark terminals - Add banner_colors() to select appropriate colors per theme - Light terminals now use DarkBlue/DarkOrange instead of Green/Yellow - Falls back to dark theme colors if detection fails (preserving existing behavior) - Add unit tests for color selection logic
Contributor
There was a problem hiding this comment.
Pull request overview
Adds automatic terminal background (luminance) detection to choose higher-contrast banner colors on light terminal themes, addressing the banner visibility complaint in #778.
Changes:
- Introduces terminal luma detection with a threshold-based “light vs dark terminal” decision.
- Switches banner/info gradient colors based on detected terminal theme (with dark-theme fallback on detection failure).
- Adds unit tests for the light/dark color mapping and introduces the
terminal-lightdependency.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/main.rs |
Adds terminal luma detection and selects banner colors accordingly; adds tests for color selection. |
Cargo.toml |
Adds terminal-light dependency to support background detection. |
Cargo.lock |
Locks transitive dependencies pulled in by terminal-light (e.g., crossterm/xterm-query). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Adds stdout/stdin TTY checks before calling terminal_light::luma() to prevent blocking or emitting control sequences in non-interactive contexts (e.g., piped output, CI/CD). Addresses Copilot's review feedback on PR bee-san#863.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds automatic terminal background detection to improve banner visibility on light themes.
terminal-lightcrate to detect terminal luminanceFixes #778