Conversation
…andling into a single function, improving code clarity and maintainability. Update tests accordingly to reflect the new verification structure.
…onventions for clarity in Nullify tests.
…ild game in AggregateVerifier. Implement corresponding test case to verify this behavior.
…d rollup configuration. Update verification methods to use a journal hash instead of root claims. Modify MockVerifier and tests accordingly.
…date validation check to use this constant
…ier, updating documentation and logic to clarify its purpose as the L2 sequence number.
…rnal to public, enhancing accessibility for contract interactions.
…fier to emit event upon credit transfer
…er for consistency with internal function naming conventions.
…nsolidating the return statement for the first dispute game scenario.
jjtny1
force-pushed
the
joby.thundil/CHAIN-3293-migrate-multiproof-contracts-to-basecontracts
branch
from
0f84ac7 to
76335ba
Compare
jjtny1
force-pushed
the
joby.thundil/CHAIN-3293-migrate-multiproof-contracts-to-basecontracts
branch
from
9efb20a to
ee8c3b9
Compare
…figgloabal initialize
* Replace onchain Nitro cert verification with Automata ZK verifier, add ISemver to multiproof contracts, wire SystemConfigGlobal into standard deploy pipeline * Integrate multiproof config into standard DeployConfig, fix TEEVerifier proof format to match AggregateVerifier's l1head change * Fix fmt * Replace aws-nitro-enclave-attestation submodule with no-git dependency in Makefile * Consolidate deploy configs: migrate dev scripts to standard DeployConfig, add multiproof fields to sepolia.json and hardhat.json, remove separate nitro config files * Regenerate snapshots for updated and new multiproof contracts * Fix Initializable test: guard ETHLockbox entries for non-interop deploys, exclude AggregateVerifier (uses custom bool instead of OZ _initialized) * Add test-multiproof recipe to Justfile for CI * Address PR feedback: extract GameType local var, stricter pubKey check, iterate PCRs, add nitroEnclaveVerifier to Input, revert sepolia.json owner, remove redundant CI recipe * Resolve merge conflicts and regenerate semver-lock snapshots * Regenerate semver-lock with CI profile for correct bytecode hashes * Regenerate semver-lock with all compiler profiles including dispute * Regenerate semver-lock.json to remove stale dispute profile entries * Fix misleading TEEVerifier comment, require nitroEnclaveVerifier in deploy config, and parameterize hardcoded l2ChainID/block intervals in DeployImplementations * Reset semvar versioning in SystemConfigGlobal * Regenerate semver-lock.json for SystemConfigGlobal and TEEVerifier changes * correct SystemConfigGlobal.t.sol testInitialization() test cases to check correct version() number * use a proof threshold and allow ZK proofs after TEE nullification (#199) * use a proof threshold and allow ZK proofs after TEE nullification * pr feedback * update deployment scripts and tests * allow tee nullfiication when a zk proof exists. extend timestamp in this case to allow for zk nullification * Fix stack-too-deep in DeployImplementations and regenerate semver-lock * add multiproofProofThreshold to DeployConfig.s.sol to fix CI failures * Correct semver comment * Regenerate semver-lock following fix --------- Co-authored-by: roger-bai-coinbase <roger.bai@coinbase.com>
leopoldjoy
approved these changes
Mar 5, 2026
Collaborator
|
Review Error for leopoldjoy @ 2026-03-05 22:42:40 UTC |
jackchuma
reviewed
Mar 5, 2026
| GameType.unwrap(ANCHOR_STATE_REGISTRY.respectedGameType()) == GameType.unwrap(GAME_TYPE); | ||
| } | ||
|
|
||
| function initializeWithInitData(bytes calldata) external payable { } |
Contributor
There was a problem hiding this comment.
Why is this here if it's empty?
Contributor
Author
There was a problem hiding this comment.
It needs to be implemented since this contract inherits IDisputeGame and we added this function for the AggregateVerifier
Contributor
There was a problem hiding this comment.
Should it be empty though?
Contributor
Author
There was a problem hiding this comment.
It shouldnt be used since init extra data is something we introduced -- everything using it currently should only be using the initialize function and this contract has no need of the extra data
jackchuma
approved these changes
Mar 6, 2026
jjtny1
deleted the
joby.thundil/CHAIN-3293-migrate-multiproof-contracts-to-basecontracts
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the contracts from https://github.com/base/multiproof-dispute-game to base contracts.
Multiproofs depend on a modified version of the DisputeGameFactory that takes arguments in the
initializeconstructor. This is done through agit patchfound inmultiproof_tests/optimism.patch. Because this patch is needed for the tests to pass, we keep all multiproof tests in the themultiproof_testsfolder and use a foundry profile to trigger it. This is abstracted into a make command:make test-multiproof