Conversation
…able reruns The tearDown in TestSyncInfra_BuildInSource_Makefile and TestSyncCode_BuildInSource_Makefile deletes the Makefile-created marker files but does not invalidate the SAM build cache inside the temp test data directory. On pytest reruns, SAM finds a valid cache and skips re-running the Makefile, so the marker files are never recreated and the file-existence assertion fails. Clear .aws-sam inside test_data_path in tearDown so the build cache is invalidated and the Makefile re-executes on retries.
seshubaws
approved these changes
Mar 11, 2026
licjun
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
TestSyncInfra_BuildInSource_Makefile::test_sync_builds_and_deploys_successfully_0integration test fails on pytest reruns due to stale SAM build cache.The
tearDowndeletes the Makefile-created marker files (file-created-from-makefile-*.txt) but does not invalidate the SAM build cache inside the temp test data directory. The base classSyncIntegBase.tearDownclears.aws-samfromos.getcwd()(the repo root), but the actual build cache lives atself.test_data_path/.aws-sam/(inside the temp directory).On pytest reruns, SAM finds a "valid cache" and skips re-running the Makefile, so the marker files are never recreated and the file-existence assertion fails with
AssertionError: False != True.Fix
Clear
.aws-saminsideself.test_data_pathintearDownfor bothTestSyncInfra_BuildInSource_MakefileandTestSyncCode_BuildInSource_Makefile, so the build cache is invalidated and the Makefile re-executes on retries.Testing
This fix addresses a flaky test rerun issue observed in CI: https://github.com/aws/aws-sam-cli/actions/runs/22754896467/job/65997092656