Skip to content

Adding Oracle Interpreter#5162

Open
psilberk wants to merge 13 commits intoapache:masterfrom
psilberk:master
Open

Adding Oracle Interpreter#5162
psilberk wants to merge 13 commits intoapache:masterfrom
psilberk:master

Conversation

@psilberk
Copy link

What is this PR for?

Add Oracle Interpreter with Oracle specific features.

What type of PR is it?

Feature

Questions:

  • Does the license files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@jongyoul
Copy link
Member

@psilberk Hello, thank you for the contribution :-) By the way, we already have a jdbc interpreter supporting oracle jdbc. You can add oracle jdbc driver inside the interpreter directory and you can connect it. Did you check it? If you have any specific feature which supports Oracle only, I strongly recommend to add logic in JdbcInterpreter properly. Could you please check it?

@psilberk
Copy link
Author

Hi @jongyoul yes! We are aware of the jdbc interpreter, we wanted to add the Oracle/jdbc to support our specific parameters for UCP (connection pooling), Wallets, tnsalias, etc... and get it ready in the future to add our specific features with the same name we use in the driver (eg: the multiple timeouts we support). Does it make sense?

@jongyoul
Copy link
Member

Sorry, what do you mean our specific feature is?

@psilberk
Copy link
Author

There are two sets of features that we were interested in implementing in this interpreter's extension:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants