fix(rest-catalog): omit null optional fields in CreateTableRequest JSON#2136
Open
jonbjo wants to merge 1 commit intoapache:mainfrom
Open
fix(rest-catalog): omit null optional fields in CreateTableRequest JSON#2136jonbjo wants to merge 1 commit intoapache:mainfrom
jonbjo wants to merge 1 commit intoapache:mainfrom
Conversation
CTTY
approved these changes
Feb 19, 2026
Collaborator
CTTY
left a comment
CTTY
left a comment
There was a problem hiding this comment.
This is a good catch, thanks for the fix! Do you mind adding an unit test to test serde as well?
We don't need to fix them in this PR, but it seems like we also have other Option left null by default during serialization
mattefunnel
added a commit
to mattefunnel/iceberg-rust
that referenced
this pull request
Feb 20, 2026
Add round-trip serialization tests that verify optional fields are omitted (not serialized as null) when absent, as requested in apache#2136. - CreateTableRequest: full and minimal round-trip serde test - UnboundPartitionSpec: assert serialized output matches expected JSON
|
I added some tests here. That branch is based off of jonbjo:fix/skip-serialize-null-fields, so technically I guess that other PR "Closes the issue" as well. Not sure what is the best way to do a "Fork of a fork". Any suggestions are welcome! |
mattefunnel
added a commit
to mattefunnel/iceberg-rust
that referenced
this pull request
Feb 20, 2026
Add round-trip serialization tests that verify optional fields are omitted (not serialized as null) when absent, as requested in apache#2136. - CreateTableRequest: full and minimal round-trip serde test - UnboundPartitionSpec: assert serialized output matches expected JSON
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Adds #[serde(skip_serializing_if = "Option::is_none")] to optional fields in REST catalog request types to prevent serializing explicit null values.
Are these changes tested?
Existing serialization tests continue to pass. This change affects JSON wire format only (omitting null vs. including it), which maintains compatibility with catalogs that accept either format while fixing compatibility with stricter implementations like Apache Polaris.