feat!(storage): Integration Storage trait with FileIO#2116
Merged
blackmwk merged 14 commits intoapache:mainfrom Mar 4, 2026
Merged
feat!(storage): Integration Storage trait with FileIO#2116blackmwk merged 14 commits intoapache:mainfrom
blackmwk merged 14 commits intoapache:mainfrom
Conversation
CTTY
commented
Feb 5, 2026
CTTY
force-pushed
the
ctty/update-fileio
branch
from
082d2d2 to
7d692d8
Compare
CTTY
force-pushed
the
ctty/update-fileio
branch
from
d74a640 to
df9dcf0
Compare
Collaborator
Author
|
Hi @blackmwk, this PR is to wrap up the phase 1 work of Storage trait and is ready for review |
…o ctty/update-fileio
gbrgr
pushed a commit
to RelationalAI/iceberg-rust
that referenced
this pull request
Mar 10, 2026
<!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - This depends on apache#2109 - Closes apache#2058 - Update `FileIO` to hold `dyn Storage` instead of `OpenDalStorage` - Update `FileIOBuilder` accordingly - Removed `Extensions` from `FileIO` - Add `with_storage_factory` in `CatalogBuilder` and update all implementations accordingly - Add an optional `dyn StorageFactory` to `IcebergTableProviderFactory` - Update other FileIOBuilder usages accordingly <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> Mostly rely on the existing tests, added some uts for FileIOBuilder <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
FileIOto holddyn Storageinstead ofOpenDalStorageFileIOBuilderaccordinglyExtensionsfromFileIOwith_storage_factoryinCatalogBuilderand update all implementations accordinglydyn StorageFactorytoIcebergTableProviderFactoryAre these changes tested?
Mostly rely on the existing tests, added some uts for FileIOBuilder