Fix HPACK table size update sequencing#651
Merged
arturobernalg merged 1 commit intoapache:masterfrom Mar 13, 2026
Merged
Conversation
ok2c
approved these changes
Mar 12, 2026
Member
ok2c
left a comment
ok2c
left a comment
There was a problem hiding this comment.
@arturobernalg I assume you know what you are doing
Signal the minimum pending table size first and the final size second
arturobernalg
force-pushed
the
hpack-table-size-update-sequencing
branch
from
13e318b to
86cbf49
Compare
Member
Author
Hi @ok2c I double-checked it against RFC 7541 §4.2 and added regression coverage for repeated table size updates between header blocks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signal the minimum pending table size first and the final size second, as required by RFC 7541 section 4.2.
- the smallest maximum table size that occurs in that interval MUST be signaled
- The final maximum size is always signaled