Skip to content

HBASE-28913 LoadBalancerPerformanceEvaluation fails with NPE#7789

Merged
Apache9 merged 1 commit intoapache:branch-2from
liuxiaocs7:HBASE-28913-branch-2
Feb 25, 2026
Merged

HBASE-28913 LoadBalancerPerformanceEvaluation fails with NPE#7789
Apache9 merged 1 commit intoapache:branch-2from
liuxiaocs7:HBASE-28913-branch-2

Conversation

@liuxiaocs7
Copy link
Contributor

@liuxiaocs7 liuxiaocs7 commented Feb 24, 2026 •
edited
Loading

liuxiaocs7
liuxiaocs7 commented Feb 24, 2026
View reviewed changes
...src/test/java/org/apache/hadoop/hbase/master/balancer/LoadBalancerPerformanceEvaluation.java
Comment on lines +94 to +96
MasterServices services = mock(MasterServices.class);
when(services.getConfiguration()).thenReturn(conf);
loadBalancer.setMasterServices(services);
Copy link
Contributor Author

@liuxiaocs7 liuxiaocs7 Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need MasterServices for LB initialize on branch-2.x, which is different from master

@liuxiaocs7
Copy link
Contributor Author

liuxiaocs7 commented Feb 25, 2026

rebase branch-2, includes #7787

@liuxiaocs7
Copy link
Contributor Author

liuxiaocs7 commented Feb 25, 2026

TestCheckTestClasses.checkClasses seems still fails when using JDK8 + Hadoop2 in this job(https://github.com/apache/hbase/actions/runs/22378733544/job/64774616226?pr=7789)

@Apache9
Copy link
Contributor

Apache9 commented Feb 25, 2026

The failed UTs should not be related.

Let me merge.

@Apache9 Apache9 merged commit 200e526 into apache:branch-2 Feb 25, 2026
15 of 19 checks passed
@Apache9
Copy link
Contributor

Apache9 commented Feb 25, 2026

TestCheckTestClasses.checkClasses seems still fails when using JDK8 + Hadoop2 in this job(https://github.com/apache/hbase/actions/runs/22378733544/job/64774616226?pr=7789)

It is broken by upgrading hbase-client to junit5, since we use junit5 MockitoExtension in hbase-client, but we do not have this dependency in hbase-server...

@liuxiaocs7 Please file an issue to add mockito-junit-jupiter to hbase-server, and remember to add a TODO that we will remove this once TestCheckTestClasses is removed.

Thanks.

@liuxiaocs7
Copy link
Contributor Author

liuxiaocs7 commented Feb 25, 2026 •
edited
Loading

TestCheckTestClasses.checkClasses seems still fails when using JDK8 + Hadoop2 in this job(https://github.com/apache/hbase/actions/runs/22378733544/job/64774616226?pr=7789)

It is broken by upgrading hbase-client to junit5, since we use junit5 MockitoExtension in hbase-client, but we do not have this dependency in hbase-server...

@liuxiaocs7 Please file an issue to add mockito-junit-jupiter to hbase-server, and remember to add a TODO that we will remove this once TestCheckTestClasses is removed.

Thanks.

Hi, @Apache9, HBASE-29925 and PR: #7798

Test with the following commands on branch-2 using JDK8, it works well

mvn test -pl hbase-server -am -Dtest=TestCheckTestClasses

and

mvn test -pl hbase-server -am -Dtest=TestCheckTestClasses -Dhadoop.profile=3.0

liuxiaocs7 added a commit to liuxiaocs7/hbase that referenced this pull request Feb 25, 2026
@liuxiaocs7
HBASE-28913 LoadBalancerPerformanceEvaluation fails with NPE (apache#…
053a714 
…7789)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
@liuxiaocs7 liuxiaocs7 mentioned this pull request Feb 25, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9 Apache9 Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liuxiaocs7 @Apache9