-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Cleanup example metadata parsing utilities(#20251) #20252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup example metadata parsing utilities(#20251) #20252
Conversation
High-level overviewThis PR follows up on review feedback and focuses on small structural and correctness improvements, without changing any user-facing behavior. Specifically, this PR:
|
|
@martin-g I’ve addressed your comments in this PR by refactoring the module structure, fixing the example group discovery edge cases, and adding tests to cover them. |
| } | ||
|
|
||
| if groups.is_empty() { | ||
| return Err(DataFusionError::Execution(format!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| return Err(DataFusionError::Execution(format!( | |
| return exec_err!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! I'm going to update to use exec_err! for consistency with the rest of code.
|
I updated the code to use |
comphead
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cj-zhukov and @Jefffrey
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?