Draft
Conversation
Contributor
Author
|
it would be great if you could have a look @timsaucer, |
965383c to
62cf3d8
Compare
Member
|
Looking good! Instead of adding a lot of comments I put up this PR targeting your branch with some recommendations: |
Contributor
Author
|
thanks @timsaucer |
* Add recommendations for query planner ffi code * remove cruft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This is WIP which exposes datafusion query planner as FFI interface,
I hope to split this PR into two separate once implementation is nailed
What changes are included in this PR?
There are few open questions
Are these changes tested?
There is one test, integration test to follow if this makes sese
Are there any user-facing changes?
yes query planner is moved to different module and signature changed