Improve ExternalSorter ResourcesExhausted Error Message #20226
+49
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
When there is not enough memory to continue external sort, either increasing the
memory limitor decreasingsort_spill_reservation_bytesneed to be applied. It can be useful to guide the user with clearer error message by highlighting required configs for the consistency because expected settings are as follows:Current:
New:
Are these changes tested?
A new UT case has been added to cover this use-case and it has been tested locally successfully.
For updated snapshot files:
Following integration tests have been successful by DataFusion Test Pipeline:
Ref: https://github.com/apache/datafusion/actions/runs/21811797863/job/62925363536?pr=20226
Are there any user-facing changes?
Yes, improving legacy
ExternalSorterResourcesExhaustedError Message.