Skip to content

Enable ! as NOT operator for Databricks dialect#2287

Merged
iffyio merged 1 commit intoapache:mainfrom
funcpp:databricks-bang-not-operator
Apr 2, 2026
Merged

Enable ! as NOT operator for Databricks dialect#2287
iffyio merged 1 commit intoapache:mainfrom
funcpp:databricks-bang-not-operator

Conversation

@funcpp
Copy link
Copy Markdown
Contributor

@funcpp funcpp commented Mar 31, 2026

Summary

  • Enable supports_bang_not_operator() for DatabricksDialect

Databricks supports !expr as a logical NOT operator.

Test plan

  • Existing parse_bang_not test in sqlparser_common.rs uses all_dialects_where(|d| d.supports_bang_not_operator()) and automatically covers Databricks
  • Full test suite passes

@funcpp funcpp mentioned this pull request Apr 2, 2026
Open
4 tasks
iffyio
iffyio approved these changes Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @funcpp!

@iffyio iffyio added this pull request to the merge queue Apr 2, 2026
Merged via the queue into apache:main with commit 913cf0e Apr 2, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iffyio iffyio iffyio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@funcpp @iffyio