Skip to content

Comments

feat: pass spark.comet.datafusion.* configs through to DataFusion session#3455

Merged
andygrove merged 5 commits intoapache:mainfrom
andygrove:pass-datafusion-configs
Feb 13, 2026
Merged

feat: pass spark.comet.datafusion.* configs through to DataFusion session#3455
andygrove merged 5 commits intoapache:mainfrom
andygrove:pass-datafusion-configs

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented Feb 9, 2026

Summary

  • Spark configs with the prefix spark.comet.datafusion.* are now passed through to DataFusion's SessionConfig
  • The spark.comet. prefix is stripped so that e.g. spark.comet.datafusion.sql_parser.parse_float_as_decimal=true becomes datafusion.sql_parser.parse_float_as_decimal=true in DataFusion
  • This allows users to tune DataFusion behavior from Spark via --conf without code changes

🤖 Generated with Claude Code

…sion

Spark configs with the prefix spark.comet.datafusion.* are now passed
through to DataFusion's SessionConfig. The prefix spark.comet. is
stripped so that e.g. spark.comet.datafusion.sql_parser.parse_float_as_decimal
becomes datafusion.sql_parser.parse_float_as_decimal in DataFusion.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@andygrove andygrove marked this pull request as ready for review February 11, 2026 18:21
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andygrove I'm happy we put back sending those user defined DF configs to the native execution

@mbutrovich
Copy link
Contributor

Are there any configs that we can think of that would absolutely break Comet correctness? Either adding to a disallow list to filter out, or warn users about?

@andygrove
Copy link
Member Author

andygrove commented Feb 12, 2026

Are there any configs that we can think of that would absolutely break Comet correctness? Either adding to a disallow list to filter out, or warn users about?

Good point. We could put this functionality behind a new config flag with appropriate documentation. Something like spark.comet.exec.respectDataFusionConfigs defaulting to false?

@mbutrovich
Copy link
Contributor

mbutrovich commented Feb 12, 2026

Are there any configs that we can think of that would absolutely break Comet correctness? Either adding to a disallow list to filter out, or warn users about?

Good point. We could put this functionality behind a new config flag with appropriate documentation. Something like spark.comet.exec.respectDataFusionConfigs defaulting to false?

At a minimum I think that's a good start. It's a huge config space, so I think guarding it behind another config that says something to the effect of "DataFusion configs are exposed for development purposes and possible workload-specific optimizations. Changing DataFusion configs could affect Comet correctness and/or stability."

@andygrove
Copy link
Member Author

Thanks for the review @mbutrovich. I added the config.

Copy link
Contributor

@mbutrovich mbutrovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @andygrove!

@andygrove andygrove merged commit d3ea9fd into apache:main Feb 13, 2026
107 checks passed
@andygrove andygrove deleted the pass-datafusion-configs branch February 13, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants